cloud-fan commented on a change in pull request #26516: [SPARK-29893] improve
the local shuffle reader performance by changing the reading task number from 1
to multi.
URL: https://github.com/apache/spark/pull/26516#discussion_r346706350
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/physical/partitioning.scala
##########
@@ -171,6 +171,13 @@ trait Partitioning {
required.requiredNumPartitions.forall(_ == numPartitions) &&
satisfies0(required)
}
+ final def changePartitionNumber(
Review comment:
I'd make this an abstract method and ask all sub-classes to implement it.
For partitioning that can't change num partitions, they should return
`UnknownPartitioning`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
