cloud-fan commented on a change in pull request #25990: [SPARK-29248][SQL] Pass
in number of partitions to WriteBuilder
URL: https://github.com/apache/spark/pull/25990#discussion_r346751013
##########
File path:
external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaSourceProvider.scala
##########
@@ -392,18 +392,14 @@ private[kafka010] class KafkaSourceProvider extends
DataSourceRegister
override def newScanBuilder(options: CaseInsensitiveStringMap):
ScanBuilder =
() => new KafkaScan(options)
- override def newWriteBuilder(options: CaseInsensitiveStringMap):
WriteBuilder = {
+ override def newWriteBuilder(options: CaseInsensitiveStringMap,
Review comment:
nit:
```
def func(
para1: T,
para2: T ...
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
