cloud-fan commented on a change in pull request #25990: [SPARK-29248][SQL] Pass 
in number of partitions to WriteBuilder
URL: https://github.com/apache/spark/pull/25990#discussion_r347084687
 
 

 ##########
 File path: 
sql/catalyst/src/main/java/org/apache/spark/sql/connector/write/BatchWrite.java
 ##########
 @@ -45,8 +45,10 @@
    *
    * If this method fails (by throwing an exception), the action will fail and 
no Spark job will be
    * submitted.
+   *
+   * @param info Physical information about the input data that will be 
written to this data writer.
 
 Review comment:
   `will be written to this data writer.`
   
   I'd say `will be written to this table`. We write one partition to each data 
writer, but the physical information is not of one partition, but the entire 
dataset.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to