holdenk commented on a change in pull request #26433: [SPARK-29771][K8S] Add
configure to limit executor failures
URL: https://github.com/apache/spark/pull/26433#discussion_r346939194
##########
File path:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsAllocator.scala
##########
@@ -145,6 +157,13 @@ private[spark] class ExecutorPodsAllocator(
logDebug(s"Pod allocation status: $currentRunningCount running, " +
s"${currentPendingExecutors.size} pending, " +
s"${newlyCreatedExecutors.size} unacknowledged.")
+
+ val numFailedExecutors =
Review comment:
I don't know about this necessarily being the best way to track the number
of failed executors. In dynamic allocation it seems like if we scaled up and
then down a few times this would give us a incorrect reading. Or is that taken
care of elsewhere?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
