holdenk commented on a change in pull request #26433: [SPARK-29771][K8S] Add
configure to limit executor failures
URL: https://github.com/apache/spark/pull/26433#discussion_r346938204
##########
File path:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/Config.scala
##########
@@ -188,6 +188,12 @@ private[spark] object Config extends Logging {
.checkValue(value => value > 0, "Allocation batch delay must be a
positive time value.")
.createWithDefaultString("1s")
+ val KUBERNETES_MAX_EXECUTOR_FAILURES =
+ ConfigBuilder("spark.kubernetes.max.executor.failures")
+ .doc("The maximum number of executor failures before failing the
application.")
+ .intConf
Review comment:
I think we could use a checkValue here for a positive number
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
