cloud-fan commented on a change in pull request #26578: [SPARK-29945][SQL] do 
not handle negative sign specially in the parser
URL: https://github.com/apache/spark/pull/26578#discussion_r347350959
 
 

 ##########
 File path: sql/core/src/test/resources/sql-tests/results/ansi/interval.sql.out
 ##########
 @@ -239,15 +239,15 @@ NULL
 -- !query 29
 select -interval '-1 month 1 day -1 second'
 -- !query 29 schema
-struct<1 months -1 days 1 seconds:interval>
+struct<(- -1 months 1 days -1 seconds):interval>
 
 Review comment:
   We should change the default alias of interval literal in a followup.
   ```
   scala> sql("select interval '1 day', date '2000-10-10'").show
   +------+-----------------+
   |1 days|DATE '2000-10-10'|
   +------+-----------------+
   |1 days|       2000-10-10|
   +------+-----------------+
   ```
   We should follow date and pick `INTERVAL '1 days'`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to