cloud-fan commented on a change in pull request #26578: [SPARK-29945][SQL] do 
not handle negative sign specially in the parser
URL: https://github.com/apache/spark/pull/26578#discussion_r347356281
 
 

 ##########
 File path: sql/core/src/test/resources/sql-tests/inputs/literals.sql
 ##########
 @@ -107,7 +107,11 @@ select integer '2147483648';
 
 -- awareness of the negative/positive sign before type
 select -integer '7';
+select +integer '7';
+select +date '1999-01-01';
+select +timestamp '1999-01-01';
+select +x'2379ACFe';
+-- can't negate date/timestamp/binary
 select -date '1999-01-01';
 select -timestamp '1999-01-01';
 select -x'2379ACFe';
-select +integer '7';
 
 Review comment:
   it's supported: 
https://github.com/apache/spark/pull/26578/files#diff-3adf2824cec2162e632a5114d3d710cdR110

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to