Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/4433#discussion_r24280703
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/linalg/EigenValueDecomposition.scala
---
@@ -79,6 +79,10 @@ private[mllib] object EigenValueDecomposition {
// Mode 1: A*x = lambda*x, A symmetric
iparam(6) = 1
+ require(ncv * n.toLong <= Integer.MAX_VALUE, "Product of 2*k*n must be
smaller than " +
--- End diff --
Sorry, one other tiny thing: the problematic product is not necessarily
2*k*n here. I think you could simplify these error messages to just say that
the k and n are too large, rather than explain the computation. Right now the
expressions are repeated 3 places. Might be nice to keep that to 2, and keep
them together.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
