Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/4433#discussion_r24281733
  
    --- Diff: 
mllib/src/main/scala/org/apache/spark/mllib/linalg/EigenValueDecomposition.scala
 ---
    @@ -79,6 +79,10 @@ private[mllib] object EigenValueDecomposition {
         // Mode 1: A*x = lambda*x, A symmetric
         iparam(6) = 1
     
    +    require(ncv * n.toLong <= Integer.MAX_VALUE, "Product of 2*k*n must be 
smaller than " +
    --- End diff --
    
    You could, sure. Yes, I'm saying the caller may just need or want to know 
that, basically, k or n is too big. It would be simpler and easier than 
maintaining a longer explanation.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to