cloud-fan commented on a change in pull request #26584: [SPARK-29951][SQL] Make
the behavior of Postgre dialect independent of ansi mode config
URL: https://github.com/apache/spark/pull/26584#discussion_r347709778
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/ParseDriver.scala
##########
@@ -101,15 +101,15 @@ abstract class AbstractSqlParser(conf: SQLConf) extends
ParserInterface with Log
lexer.removeErrorListeners()
lexer.addErrorListener(ParseErrorListener)
lexer.legacy_setops_precedence_enbled = conf.setOpsPrecedenceEnforced
- lexer.ansi = conf.dialectSparkAnsiEnabled
+ lexer.ansi = conf.ansiEnabled
Review comment:
I'd like to change the flag name, e.g.
```
lexer.use_SQL_standard_keywords = conf.dialect match {
case pgsql => true
case spark => conf. dialectSparkAnsiEnabled
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
