cloud-fan commented on a change in pull request #26584: [SPARK-29951][SQL] Make
the behavior of Postgre dialect independent of ansi mode config
URL: https://github.com/apache/spark/pull/26584#discussion_r347888161
##########
File path:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4
##########
@@ -951,7 +957,8 @@ number
| MINUS? BIGDECIMAL_LITERAL #bigDecimalLiteral
;
-// When `spark.sql.dialect.spark.ansi.enabled=true`, there are 2 kinds of
keywords in Spark SQL.
+// When we use PostgreSQL dialect or use Spark dialect with
+// `spark.sql.dialect.spark.ansi.enabled=true`, there are 2 kinds of keywords
in Spark SQL.
Review comment:
We can simply say "when use_SQL_standard_keywords=true". The parser doesn't
care when it is true, we should explain it in the caller side.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
