xuanyuanking commented on a change in pull request #26584: [SPARK-29951][SQL]
Make the behavior of Postgre dialect independent of ansi mode config
URL: https://github.com/apache/spark/pull/26584#discussion_r348300581
##########
File path:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4
##########
@@ -46,9 +46,9 @@ grammar SqlBase;
}
/**
- * When true, ANSI SQL parsing mode is enabled.
+ * When true, use ANSI SQL standard keywords.
*/
- public boolean ansi = false;
+ public boolean use_SQL_standard_keywords = false;
Review comment:
Thanks for the suggestion, how about keep both `keyword` and `behavior` in
this flag, cause for the comment here, it is still closely related with
keywords?
https://github.com/apache/spark/blob/5a70af7a6c271e12a1f8b508dcede804e30a1b75/sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4#L954-L960
I do this temporarily in c05adb9. Please let me know if you don't agree :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
