xuanyuanking commented on a change in pull request #26584: [SPARK-29951][SQL]
Make the behavior of Postgre dialect independent of ansi mode config
URL: https://github.com/apache/spark/pull/26584#discussion_r348338945
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/ParseDriver.scala
##########
@@ -88,19 +89,26 @@ abstract class AbstractSqlParser(conf: SQLConf) extends
ParserInterface with Log
protected def parse[T](command: String)(toResult: SqlBaseParser => T): T = {
logDebug(s"Parsing command: $command")
+ // When we use PostgreSQL dialect or use Spark dialect with setting
+ // `spark.sql.dialect.spark.ansi.enabled=true`, the parser will use ANSI
SQL standard keywords.
+ val useSQLStandardKeywords = conf.dialect match {
Review comment:
Thanks, done in 5a4b2ea.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]