HeartSaVioR commented on a change in pull request #26201: [SPARK-29543][SS][UI]
Init structured streaming ui
URL: https://github.com/apache/spark/pull/26201#discussion_r348314125
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/ProgressReporter.scala
##########
@@ -81,6 +81,9 @@ trait ProgressReporter extends Logging {
/** Holds the most recent query progress updates. Accesses must lock on the
queue itself. */
private val progressBuffer = new mutable.Queue[StreamingQueryProgress]()
+ /** Count the total input records of this streaming query. */
Review comment:
My 2 cents was that `total input records` doesn't seem to be valuable to
calculate and show up in UI, especially given it's the only one metric which
requires accumulation among batches.
But it might be only me, so let's hear other voices. If we don't see clear
benefit of it, we can simply drop QuerySummary as QuerySummary exists only for
`total input records`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
