HeartSaVioR commented on a change in pull request #26201: [SPARK-29543][SS][UI]
Init structured streaming ui
URL: https://github.com/apache/spark/pull/26201#discussion_r348326763
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/streaming/StreamingQueryManager.scala
##########
@@ -393,7 +392,7 @@ class StreamingQueryManager private[sql] (sparkSession:
SparkSession) extends Lo
private def unregisterTerminatedStream(terminatedQueryId: UUID): Unit = {
activeQueriesLock.synchronized {
// remove from shared state only if the streaming query manager also
matches
-
sparkSession.sharedState.activeStreamingQueries.remove(terminatedQueryId, this)
+ sparkSession.sharedState.streamQueryStore.terminate(terminatedQueryId)
Review comment:
Looks like this change breaks the intention commented above; If I understand
correctly, the intention is to collect all queries in shared state to prevent
other session to launch same query, with applying proper isolation to prevent
other session to remove query from shared state. StreamQueryStore doesn't
consider isolation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
