maropu commented on a change in pull request #26615: [SPARK-29977][SQL] Remove
newMutableProjection/newOrdering/newNaturalAscendingOrdering from SparkPlan
URL: https://github.com/apache/spark/pull/26615#discussion_r348904944
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/ordering.scala
##########
@@ -102,4 +112,26 @@ object RowOrdering {
* Returns true iff outputs from the expressions can be ordered.
*/
def isOrderable(exprs: Seq[Expression]): Boolean = exprs.forall(e =>
isOrderable(e.dataType))
+
+ override protected def createCodeGeneratedObject(in: Seq[SortOrder]):
BaseOrdering = {
+ GenerateOrdering.generate(in)
+ }
+
+ override protected def createInterpretedObject(in: Seq[SortOrder]):
BaseOrdering = {
+ new InterpretedOrdering(in)
+ }
+
+ def create(order: Seq[SortOrder], inputSchema: Seq[Attribute]):
Ordering[InternalRow] = {
Review comment:
ah, yes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
