maropu commented on a change in pull request #26615: [SPARK-29977][SQL] Remove
newMutableProjection/newOrdering/newNaturalAscendingOrdering from SparkPlan
URL: https://github.com/apache/spark/pull/26615#discussion_r348955322
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/ordering.scala
##########
@@ -19,18 +19,28 @@ package org.apache.spark.sql.catalyst.expressions
import org.apache.spark.sql.catalyst.InternalRow
import org.apache.spark.sql.catalyst.expressions.BindReferences.bindReferences
+import org.apache.spark.sql.catalyst.expressions.codegen.GenerateOrdering
import org.apache.spark.sql.types._
+/**
+ * A base class for generated/interpreted row ordering.
+ */
+class BaseOrdering extends Ordering[InternalRow] {
+ def compare(a: InternalRow, b: InternalRow): Int = {
Review comment:
Let's check in the latest commit ;)
But, my guess is that we need to implement it based on the exception message:
```
File 'generated.java', Line 5, Column 1: Non-abstract class
"org.apache.spark.sql.catalyst.expressions.GeneratedClass$SpecificOrdering"
must implement method "public abstract int
scala.math.Ordering.compare(java.lang.Object, java.lang.Object)"
at
...
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
