cloud-fan commented on a change in pull request #26622: [WIP][SPARK-28023][Test] Cheap UTF8String Trim URL: https://github.com/apache/spark/pull/26622#discussion_r349015970
########## File path: sql/core/src/test/resources/sql-tests/inputs/comparator.sql ########## @@ -1,3 +1,12 @@ -- binary type select x'00' < x'0f'; select x'00' < x'ff'; + +-- trim string to numeric +select '1 ' = 1Y; +select '1 ' = 1S; +select '1 ' = 1; Review comment: For this simple case, how much slower we are compared to the master branch? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
