gatorsmile commented on a change in pull request #26625:
[SPARK-29893][SQL][followup] code cleanup for local shuffle reader
URL: https://github.com/apache/spark/pull/26625#discussion_r349397748
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/LocalShuffledRowRDD.scala
##########
@@ -57,38 +57,20 @@ private final class LocalShuffledRowRDDPartition(
class LocalShuffledRowRDD(
var dependency: ShuffleDependency[Int, InternalRow, InternalRow],
metrics: Map[String, SQLMetric],
- advisoryParallelism : Option[Int] = None)
+ partitionStartIndices: Array[Array[Int]])
Review comment:
Add the parameter parameter in the description ?
```
* @param partitionStartIndices A mapper usually writes many shuffle blocks,
and it's better to
* launch multiple tasks to read shuffle blocks
of one mapper. This
* array contains the partition start indices
for each mapper.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
