gatorsmile commented on a change in pull request #26625:
[SPARK-29893][SQL][followup] code cleanup for local shuffle reader
URL: https://github.com/apache/spark/pull/26625#discussion_r349407779
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/ShuffleExchangeExec.scala
##########
@@ -83,9 +83,8 @@ case class ShuffleExchangeExec(
new ShuffledRowRDD(shuffleDependency, readMetrics, partitionStartIndices)
}
- def createLocalShuffleRDD(
- advisoryParallelism: Option[Int] = None): LocalShuffledRowRDD = {
- new LocalShuffledRowRDD(shuffleDependency, readMetrics,
advisoryParallelism)
+ def createLocalShuffleRDD(partitionStartIndices: Array[Array[Int]]):
LocalShuffledRowRDD = {
Review comment:
We need a better argument name. This is sharing the same argument name as
createShuffledRDD, but the semantics are not completely same. It looks hard to
understand the values in Array[Array[Int]].
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
