Github user florianverhein commented on a diff in the pull request:

    https://github.com/apache/spark/pull/4385#discussion_r24278389
  
    --- Diff: ec2/spark_ec2.py ---
    @@ -1007,6 +1023,11 @@ def real_main():
             print >> stderr, "ebs-vol-num cannot be greater than 8"
             sys.exit(1)
     
    +    # Prevent breaking ami_prefix
    --- End diff --
    
    Sure, why not. Will wait for any other changes to this.
    I think it's a pretty rare case, which currently would just fail at with 
"Could not resolve AMI at:  ...". But we may as well cover it. 
     


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to