Github user nchammas commented on a diff in the pull request:

    https://github.com/apache/spark/pull/4385#discussion_r24224602
  
    --- Diff: ec2/spark_ec2.py ---
    @@ -1007,6 +1022,14 @@ def real_main():
             print >> stderr, "ebs-vol-num cannot be greater than 8"
             sys.exit(1)
     
    +    # Limit naming to avoid breaking things, as we rely on the repo
    --- End diff --
    
    Can't we allow people to name the repo whatever they want? All we need to 
do is make sure the repo gets cloned to `spark-ec2` regardless of what it is 
actually called, no?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to