konjac commented on a change in pull request #26627: [SPARK-29987][SQL] Add
CatalogTable cache in SessionCatalog to improve performance
URL: https://github.com/apache/spark/pull/26627#discussion_r349536520
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/StaticSQLConf.scala
##########
@@ -69,6 +69,15 @@ object StaticSQLConf {
.checkValue(cacheSize => cacheSize >= 0, "The maximum size of the cache
must not be negative")
.createWithDefault(1000)
+ val FILESOURCE_TABLE_CATALOG_CACHE_EXPIRE_SECONDS =
+ buildStaticConf("spark.sql.filesourceTableCatalogCacheExpireSeconds")
+ .internal()
+ .doc("The maximum expire seconds time of cache table catalog.")
+ .intConf
+ .checkValue(cacheSize => cacheSize >= 0 && cacheSize < 8,
Review comment:
`cacheSize` seems being copied from existing config items. Need rewording.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
