konjac commented on a change in pull request #26627: [SPARK-29987][SQL] Add
CatalogTable cache in SessionCatalog to improve performance
URL: https://github.com/apache/spark/pull/26627#discussion_r349543183
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
##########
@@ -222,6 +228,7 @@ class SessionCatalog(
if (cascade && databaseExists(dbName)) {
listTables(dbName).foreach { t =>
invalidateCachedTable(QualifiedTableName(dbName, t.table))
Review comment:
These two methods `invalidateCachedTable` and `invalidateCachedCatalogTable`
are really confusing in their names. I suggest to introduce some rewording to
let the names more intuitive.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
