squito commented on a change in pull request #24132: [SPARK-27189][CORE] Add
Executor metrics and memory usage instrumentation to the metrics system
URL: https://github.com/apache/spark/pull/24132#discussion_r349790120
##########
File path: core/src/main/scala/org/apache/spark/SparkContext.scala
##########
@@ -2473,8 +2484,10 @@ class SparkContext(config: SparkConf) extends Logging {
}
/** Reports heartbeat metrics for the driver. */
- private def reportHeartBeat(): Unit = {
+ private def reportHeartBeat(executorMetricsSource: ExecutorMetricsSource):
Unit = {
val currentMetrics = ExecutorMetrics.getCurrentMetrics(env.memoryManager)
+ executorMetricsSource.updateMetricsSnapshot(currentMetrics)
Review comment:
won't this be an NPE if its not enabled? another reason to use an Option
here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
