squito commented on a change in pull request #24132: [SPARK-27189][CORE] Add
Executor metrics and memory usage instrumentation to the metrics system
URL: https://github.com/apache/spark/pull/24132#discussion_r349723129
##########
File path: core/src/main/scala/org/apache/spark/SparkContext.scala
##########
@@ -551,9 +551,16 @@ class SparkContext(config: SparkConf) extends Logging {
_dagScheduler = new DAGScheduler(this)
_heartbeatReceiver.ask[Boolean](TaskSchedulerIsSet)
+ val executorMetricsSource =
+ if (_conf.get(METRICS_EXECUTORMETRICS_SOURCE_ENABLED)) {
+ new ExecutorMetricsSource
+ } else {
+ null
Review comment:
use an `Option` here, like we do for other optional members of SparkContext
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
