maropu commented on a change in pull request #26644: [SPARK-30004][SQL] Allow 
merge UserDefinedType into a native DataType
URL: https://github.com/apache/spark/pull/26644#discussion_r350189632
 
 

 ##########
 File path: sql/catalyst/src/test/scala/org/apache/spark/sql/types/TestUDT.scala
 ##########
 @@ -58,4 +63,22 @@ object TestUDT {
 
     override def equals(other: Any): Boolean = 
other.isInstanceOf[MyDenseVectorUDT]
   }
+
+  private[sql] class MyXMLGregorianCalendarUDT extends 
UserDefinedType[XMLGregorianCalendar] {
 
 Review comment:
   Can you use the existing UDT for testing this pr instead of defining the new 
UDT?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to