maropu commented on a change in pull request #26644: [SPARK-30004][SQL] Allow 
merge UserDefinedType into a native DataType
URL: https://github.com/apache/spark/pull/26644#discussion_r350487326
 
 

 ##########
 File path: 
sql/catalyst/src/main/scala/org/apache/spark/sql/types/StructType.scala
 ##########
 @@ -453,7 +453,23 @@ case class StructType(fields: Array[StructField]) extends 
DataType with Seq[Stru
    * 3. If B doesn't exist in `this`, it's also included in the result schema.
    * 4. Otherwise, `this` and `that` are considered as conflicting schemas and 
an exception would be
    *    thrown.
+   *
 
 Review comment:
   The statements below are duplicate with ones in L447-L455. Can you add some 
statements for this fix based on the existing  L447-L455 statements instead of 
totally re-writing comments?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to