Ngone51 commented on a change in pull request #26665: [MINOR][CORE] Make
EventLogger codec be consistent between EventLogFileWriter and SparkContext
URL: https://github.com/apache/spark/pull/26665#discussion_r350286803
##########
File path: core/src/main/scala/org/apache/spark/SparkContext.scala
##########
@@ -444,7 +445,7 @@ class SparkContext(config: SparkConf) extends Logging {
_eventLogCodec = {
val compress = _conf.get(EVENT_LOG_COMPRESS)
if (compress && isEventLogEnabled) {
-
Some(CompressionCodec.getCodecName(_conf)).map(CompressionCodec.getShortName)
+
Some(EventLogFileWriter.codecName(_conf)).map(CompressionCodec.getShortName)
Review comment:
Any reason for reducing dependencies on "these classes" ?
"change the other one" ?
Maybe, just use `_conf .get(EVENT_LOG_COMPRESSION_CODEC)` without adding
dependency on `EventLogFileWriter` should be OK ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
