koeninger commented on a change in pull request #26655: [SPARK-29293][BUILD] 
Update scalafmt plugin to 1.0.2 for compatibility with Scala 2.13
URL: https://github.com/apache/spark/pull/26655#discussion_r350290496
 
 

 ##########
 File path: dev/scalafmt
 ##########
 @@ -17,7 +17,4 @@
 # limitations under the License.
 #
 
-# by default, format only files that differ from git master
-params="${@:---diff}"
-
-./build/mvn mvn-scalafmt_2.12:format -Dscalafmt.skip=false 
-Dscalafmt.parameters="$params"
+./build/mvn mvn-scalafmt_2.12:format -Dscalafmt.skip=false
 
 Review comment:
   Even if we figure out what's up with parameters, this would need to be 
either scalafmt_2.12 or scalafmt_2.13 accordingly

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to