koeninger commented on a change in pull request #26655: [SPARK-29293][BUILD]
Update scalafmt plugin to 1.0.2 for compatibility with Scala 2.13
URL: https://github.com/apache/spark/pull/26655#discussion_r350290158
##########
File path: pom.xml
##########
@@ -166,7 +166,6 @@
<commons.collections.version>3.2.2</commons.collections.version>
<scala.version>2.12.10</scala.version>
<scala.binary.version>2.12</scala.binary.version>
- <scalafmt.parameters>--diff --test</scalafmt.parameters>
Review comment:
I'm in favor of trying to keep this functionality, since "nit: 4 spaces" is
not a welcoming first experience for new contributors.
It looks like the plugin stopped using the cli interface to scalafmt, which
is why parameters aren't accepted anymore. I've opened
https://github.com/SimonJPegg/mvn_scalafmt/issues/48 to see if the plugin
author has any suggestions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
