HeartSaVioR commented on a change in pull request #26692: [SPARK-30060][CORE][SS] Rename metrics enable/disable configs URL: https://github.com/apache/spark/pull/26692#discussion_r351538059
########## File path: docs/monitoring.md ########## @@ -984,7 +984,7 @@ This is the component with the largest amount of instrumented metrics - namespace=spark.streaming - **note:** This applies to Spark Structured Streaming only. Conditional to a configuration - parameter: `spark.sql.streaming.metricsEnabled=true` (default is false) + parameter: `spark.metrics.sparkStreamingSource.enabled` (default is false) Review comment: We may want to differentiate DStream and Structured Streaming. Before the change it is clear that it's for Structured Streaming (sql.streaming) which new name is not clear about that. Maybe `structuredStreamingSource` or even only require the metric name rule as `spark.metrics` as prefix and `enabled` as postfix so that it can use `sql.streaming`? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
