HeartSaVioR commented on a change in pull request #26692:
[SPARK-30060][CORE][SS] Rename metrics enable/disable configs
URL: https://github.com/apache/spark/pull/26692#discussion_r351538671
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -1293,7 +1293,7 @@ object SQLConf {
.createWithDefault(true)
val STREAMING_METRICS_ENABLED =
- buildConf("spark.sql.streaming.metricsEnabled")
+ buildConf("spark.metrics.sparkStreamingSource.enabled")
Review comment:
Adding the voice of name name here: we may want to differentiate DStream and
Structured Streaming. Before the change it is clear that it's for Structured
Streaming (sql.streaming) which new name is not clear about that. If we want to
only mention `streaming` it should also mention `sql`. If we are OK to have
`structuredStreaming` as a part of name, that's fine.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
