Github user MiguelPeralvo commented on the pull request:
https://github.com/apache/spark/pull/4457#issuecomment-73536251
@nchammas,
Regarding the help text, I'd say that it applies to the destroy, login,
reboot-slaves, get-master, stop and start options, not only launch. Something
like "EC2 region to launch/destroy/login/reboot-slaves/get-master/stop/start
instances in" or "EC2 region where to apply options to:
launch/destroy/login/reboot-slaves/get-master/stop/start instances in".
Regarding the region being printed when launching a cluster: As the
"get_existing_cluster()" method gets used by the launch option (also by
destroy, login, reboot-slaves, get-master, stop and start), the region will get
printed for all these options if the proposed change is applied. I'm in favor
of the region being printed out. For example, this would be the beginning of
the output of a launch execution:
```
Miguels-MacBook-Pro:ec2 Miguel$ $SPARK_HOME/ec2/spark-ec2 -k xyzapachespark
-i $SSH_HOME/xyzapachespark.pem -r eu-west-1 launch my-spark-cluster
Setting up security groups...
Searching for existing cluster my-spark-cluster in region eu-west-1...
Spark AMI: ami-1ae0166d
Launching instances...
Launched 1 slaves in eu-west-1c, regid = r-679b8425
Launched master in eu-west-1c, regid = r-e69d82a4
...
```
If we don't apply the proposed change to the "get_existing_cluster()"
method, the zone appears, but not the region. For example, this would be the
beginning of the output of a launch execution:
```
Setting up security groups...
Searching for existing cluster my-spark-cluster ...
Spark AMI: ami-1ae0166d
Launching instances...
Launched 1 slaves in eu-west-1c, regid = r-679b8425
Launched master in eu-west-1c, regid = r-e69d82a4
...
Warning: Permanently added
'ec2-54-194-24-152.eu-west-1.compute.amazonaws.com,54.194.24.152' (RSA) to the
list of known hosts.
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
