yaooqinn commented on a change in pull request #26412: [SPARK-29774][SQL] Date
and Timestamp type +/- null should be null as Postgres
URL: https://github.com/apache/spark/pull/26412#discussion_r353032872
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
##########
@@ -246,6 +247,68 @@ class Analyzer(
CleanupAliases)
)
+ /**
+ * For [[UnresolvedAdd]]:
+ * 1. If one side is timestamp/date/string and the other side is interval,
turns it to
Review comment:
neither for pg,
```
postgres=# select cast(1 as interval);
ERROR: cannot cast type integer to interval
LINE 1: select cast(1 as interval);
^
postgres=# select cast(1 as date);
ERROR: cannot cast type integer to date
LINE 1: select cast(1 as date);
^
postgres=# select interval '1' day + 1;
ERROR: operator does not exist: interval + integer
LINE 1: select interval '1' day + 1;
^
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
