yaooqinn commented on a change in pull request #26412: [SPARK-29774][SQL] Date
and Timestamp type +/- null should be null as Postgres
URL: https://github.com/apache/spark/pull/26412#discussion_r353221948
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/dsl/package.scala
##########
@@ -68,10 +68,10 @@ package object dsl {
def unary_! : Predicate = Not(expr)
def unary_~ : Expression = BitwiseNot(expr)
- def + (other: Expression): Expression = Add(expr, other)
- def - (other: Expression): Expression = Subtract(expr, other)
- def * (other: Expression): Expression = Multiply(expr, other)
- def / (other: Expression): Expression = Divide(expr, other)
+ def + (other: Expression): Expression = UnresolvedAdd(expr, other)
Review comment:
yea, I will change this back, I'am suffering tests fail with this change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
