cloud-fan commented on a change in pull request #26736: [SPARK-30098][SQL] Use
default datasource as provider for CREATE TABLE syntax
URL: https://github.com/apache/spark/pull/26736#discussion_r353747215
##########
File path:
sql/hive/src/test/scala/org/apache/spark/sql/hive/ErrorPositionSuite.scala
##########
@@ -23,13 +23,18 @@ import org.scalatest.BeforeAndAfterEach
import org.apache.spark.sql.{AnalysisException, QueryTest}
import org.apache.spark.sql.catalyst.util.quietly
-import org.apache.spark.sql.hive.test.TestHiveSingleton
+import org.apache.spark.sql.hive.test.{TestHive, TestHiveSingleton}
+import org.apache.spark.sql.internal.SQLConf
class ErrorPositionSuite extends QueryTest with TestHiveSingleton with
BeforeAndAfterEach {
import spark.implicits._
+ private val originalCreateHiveTable =
TestHive.conf.createHiveTableByDefaultEnabled
+
+
override protected def beforeEach(): Unit = {
super.beforeEach()
+ TestHive.conf.setConf(SQLConf.LEGACY_CREATE_HIVE_TABLE_BY_DEFAULT_ENABLED,
true)
Review comment:
This test suite seems to test SELECT queries mostly. Where do we create
tables?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
