cloud-fan commented on a change in pull request #26736: [SPARK-30098][SQL] Use default datasource as provider for CREATE TABLE syntax URL: https://github.com/apache/spark/pull/26736#discussion_r353750839
########## File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveMetastoreCatalogSuite.scala ########## @@ -44,9 +44,16 @@ class HiveMetastoreCatalogSuite extends TestHiveSingleton with SQLTestUtils { } test("duplicated metastore relations") { - val df = spark.sql("SELECT * FROM src") - logInfo(df.queryExecution.toString) - df.as('a).join(df.as('b), $"a.key" === $"b.key") + val originalCreateHiveTable = TestHive.conf.createHiveTableByDefaultEnabled + try { + TestHive.conf.setConf(SQLConf.LEGACY_CREATE_HIVE_TABLE_BY_DEFAULT_ENABLED, true) + val df = spark.sql("SELECT * FROM src") Review comment: I believe many changes can be reverted if we fix `TestHive`. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org