HeartSaVioR commented on a change in pull request #26771: [SPARK-30143][SS] Add
a timeout on stopping a streaming query
URL: https://github.com/apache/spark/pull/26771#discussion_r354639781
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -1258,6 +1258,14 @@ object SQLConf {
.timeConf(TimeUnit.MILLISECONDS)
.createWithDefault(10L)
+ val STREAMING_STOP_TIMEOUT =
+ buildConf("spark.sql.streaming.stopTimeout")
+ .doc("How long to wait for the streaming execution thread to stop when
calling the " +
+ "streaming query's stop() method in milliseconds. 0 means to wait
infinitely. Setting a " +
Review comment:
I'd assert the value in configuration side instead of throwing
IllegalArgumentException when calling stop() - that fits better for "fail-fast".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
