HeartSaVioR commented on a change in pull request #26771: [SPARK-30143][SS] Add
a timeout on stopping a streaming query
URL: https://github.com/apache/spark/pull/26771#discussion_r354646065
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -1258,6 +1258,14 @@ object SQLConf {
.timeConf(TimeUnit.MILLISECONDS)
.createWithDefault(10L)
+ val STREAMING_STOP_TIMEOUT =
Review comment:
I think that's not the Spark way now - Spark doesn't add the representation
of unit if `timeConf` is being used.
I might tend to agree it may be confused to figure out the actual unit
without looking at the code, in dev's perspective. (Some configurations have
second as unit, while other configurations have millisecond as unit.) For end
users' perspective they can always specify the value as string with unit, so it
makes sense to get rid of unit representation from configuration key.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
