imback82 commented on a change in pull request #26741: [SPARK-30104][SQL] Fix
catalog resolution for 'global_temp'
URL: https://github.com/apache/spark/pull/26741#discussion_r354661019
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/connector/catalog/LookupCatalog.scala
##########
@@ -133,7 +133,11 @@ private[sql] trait LookupCatalog extends Logging {
// For example, if the name of a custom catalog is the same with
`GLOBAL_TEMP_DATABASE`,
// this custom catalog can't be accessed.
if (nameParts.head.equalsIgnoreCase(globalTempDB)) {
Review comment:
good idea! I am also thinking combining `CatalogAndIdentifier` and
`CatalogAndIdentifierParts` into one such that catalog resolution is
consistent. For example, if you resolve `global_temp.t` with
`CatalogAndIdentifier`, catalog can be resolved as a v2 catalog named
`global_temp`. I haven't tested if this regresses, but what do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
