maropu commented on a change in pull request #26699: [SPARK-30066][SQL]
Columnar execution support for interval types
URL: https://github.com/apache/spark/pull/26699#discussion_r355239442
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/columnar/ColumnStats.scala
##########
@@ -295,6 +295,28 @@ private[columnar] final class BinaryColumnStats extends
ColumnStats {
Array[Any](null, null, nullCount, count, sizeInBytes)
}
+private[columnar] final class IntervalColumnStats extends ColumnStats {
+ protected var upper: CalendarInterval =
+ new CalendarInterval(Int.MinValue, Int.MinValue, Long.MinValue)
Review comment:
How about defining constant values for min/max, e.g.,
`CalendarInterval.MinValue`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
