maropu commented on a change in pull request #26699: [SPARK-30066][SQL] Columnar execution support for interval types URL: https://github.com/apache/spark/pull/26699#discussion_r355237768
########## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/columnar/ColumnAccessor.scala ########## @@ -104,6 +105,10 @@ private[columnar] class BinaryColumnAccessor(buffer: ByteBuffer) extends BasicColumnAccessor[Array[Byte]](buffer, BINARY) with NullableColumnAccessor +private[columnar] class IntervalColumnAccessor(buffer: ByteBuffer, dataType: CalendarIntervalType) + extends BasicColumnAccessor[CalendarInterval](buffer, CALENDAR_INTERVAL) + with NullableColumnAccessor Review comment: nit: two indents along with the others. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
