cloud-fan commented on a change in pull request #26808: [SPARK-30184][SQL]
Implement a helper method for aliasing functions
URL: https://github.com/apache/spark/pull/26808#discussion_r355816405
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala
##########
@@ -302,14 +302,14 @@ object FunctionRegistry {
expression[Skewness]("skewness"),
expression[ApproximatePercentile]("percentile_approx"),
expression[ApproximatePercentile]("approx_percentile"),
- expression[StddevSamp]("std"),
- expression[StddevSamp]("stddev"),
+ expressionWithAlias[StddevSamp]("std"),
+ expressionWithAlias[StddevSamp]("stddev"),
expression[StddevPop]("stddev_pop"),
- expression[StddevSamp]("stddev_samp"),
+ expressionWithAlias[StddevSamp]("stddev_samp"),
Review comment:
can we put them closer if they use the same expression?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
