cloud-fan commented on a change in pull request #26808: [SPARK-30184][SQL]
Implement a helper method for aliasing functions
URL: https://github.com/apache/spark/pull/26808#discussion_r356432239
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/ExpressionParserSuite.scala
##########
@@ -794,12 +794,18 @@ class ExpressionParserSuite extends AnalysisTest {
}
test("Support respect nulls keywords for first_value and last_value") {
- assertEqual("first_value(a ignore nulls)", First('a,
Literal(true)).toAggregateExpression())
- assertEqual("first_value(a respect nulls)", First('a,
Literal(false)).toAggregateExpression())
- assertEqual("first_value(a)", First('a,
Literal(false)).toAggregateExpression())
- assertEqual("last_value(a ignore nulls)", Last('a,
Literal(true)).toAggregateExpression())
- assertEqual("last_value(a respect nulls)", Last('a,
Literal(false)).toAggregateExpression())
- assertEqual("last_value(a)", Last('a,
Literal(false)).toAggregateExpression())
+ assertEqual("first_value(a ignore nulls)",
+ First('a, Literal(true)).toAggregateExpression())
Review comment:
ditto, unnecessary change
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
