brkyvz commented on a change in pull request #26817: [SPARK-30192][SQL] support 
column position in DS v2
URL: https://github.com/apache/spark/pull/26817#discussion_r356291201
 
 

 ##########
 File path: 
sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/TableChange.java
 ##########
 @@ -259,6 +298,60 @@ public int hashCode() {
     }
   }
 
+  interface ColumnPosition {
+    First FIRST = new First();
+
+    static ColumnPosition After(String[] column) {
 
 Review comment:
   Also should AFTER take a multipart identifier? Should the syntax be:
   ```
   ALTER TABLE ADD COLUMN m.n.y STRING AFTER x
   ```
   where x is a column after the nested field `m.n.x`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to