brkyvz commented on a change in pull request #26817: [SPARK-30192][SQL] support
column position in DS v2
URL: https://github.com/apache/spark/pull/26817#discussion_r356292278
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/DDLParserSuite.scala
##########
@@ -588,22 +600,31 @@ class DDLParserSuite extends AnalysisTest {
Seq("table_name"),
Seq("a", "b", "c"),
None,
- Some("new comment")))
+ Some("new comment"),
+ None))
}
- test("alter table: update column type and comment") {
+ test("alter table: update column position") {
comparePlans(
- parsePlan("ALTER TABLE table_name CHANGE COLUMN a.b.c TYPE bigint
COMMENT 'new comment'"),
+ parsePlan("ALTER TABLE table_name CHANGE COLUMN a.b.c FIRST"),
AlterTableAlterColumnStatement(
Seq("table_name"),
Seq("a", "b", "c"),
- Some(LongType),
- Some("new comment")))
+ None,
+ None,
+ Some(FIRST)))
}
- test("alter table: change column position (not supported)") {
- assertUnsupported("ALTER TABLE table_name CHANGE COLUMN name COMMENT 'doc'
FIRST")
- assertUnsupported("ALTER TABLE table_name CHANGE COLUMN name TYPE INT
AFTER other_col")
+ test("alter table: update column type, comment and position") {
+ comparePlans(
+ parsePlan("ALTER TABLE table_name CHANGE COLUMN a.b.c " +
+ "TYPE bigint COMMENT 'new comment' AFTER x.y"),
Review comment:
what does it mean to put `a.b.c` after `x.y`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
