rdblue commented on a change in pull request #26817: [SPARK-30192][SQL] support
column position in DS v2
URL: https://github.com/apache/spark/pull/26817#discussion_r356901739
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/connector/catalog/CatalogV2Implicits.scala
##########
@@ -89,13 +89,7 @@ private[sql] object CatalogV2Implicits {
}
implicit class IdentifierHelper(ident: Identifier) {
- def quoted: String = {
- if (ident.namespace.nonEmpty) {
- ident.namespace.map(quote).mkString(".") + "." + quote(ident.name)
- } else {
- quote(ident.name)
- }
- }
+ def quoted: String = ident.toString
Review comment:
Identifier is an interface, so we can't rely on its `toString` method to
have predictable behavior. This should use the original implementation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
