rdblue commented on a change in pull request #26817: [SPARK-30192][SQL] support
column position in DS v2
URL: https://github.com/apache/spark/pull/26817#discussion_r356902718
##########
File path:
sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/TableChange.java
##########
@@ -259,6 +298,64 @@ public int hashCode() {
}
}
+ interface ColumnPosition {
+ First FIRST = new First();
Review comment:
It's awkward for this to expose `ColumnPosition.FIRST` and
`ColumnPosition.after`. Can you add a static method `first` that returns
`First.INSTANCE` instead?
Also, if this is to be a singleton then the constructor for `First` should
be private, as should `First.INSTANCE`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
