cloud-fan commented on a change in pull request #26678: [SPARK-30226][SQL]
Remove withXXX functions in WriteBuilder
URL: https://github.com/apache/spark/pull/26678#discussion_r357019681
##########
File path:
sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/StagedTable.java
##########
@@ -32,10 +33,11 @@
* {@link StagingTableCatalog#stageCreate(Identifier, StructType, Transform[],
Map)} or
* {@link StagingTableCatalog#stageReplace(Identifier, StructType,
Transform[], Map)} to prepare the
* table for being written to. This table should usually implement {@link
SupportsWrite}. A new
- * writer will be constructed via {@link
SupportsWrite#newWriteBuilder(CaseInsensitiveStringMap)},
- * and the write will be committed. The job concludes with a call to {@link
#commitStagedChanges()},
- * at which point implementations are expected to commit the table's metadata
into the metastore
- * along with the data that was written by the writes from the write builder
this table created.
+ * writer will be constructed via
+ * {@link SupportsWrite#newWriteBuilder(CaseInsensitiveStringMap,
LogicalWriteInfo)}, and the write
Review comment:
this needs update.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
